fix(ci): wire GitLab CI to publish the system-tests image - #4079
fix(ci): wire GitLab CI to publish the system-tests image#4079MilanGarnier wants to merge 1 commit into
Conversation
|
7f3f283 to
27419ba
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27419ba1bf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| rules: | ||
| - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH | ||
| when: never | ||
| - if: $HAS_OPEN_PR != "true" |
There was a problem hiding this comment.
GitLab evaluates rules before any upstream job runs, so the dotenv report emitted by check open pr for system tests cannot populate HAS_OPEN_PR here (see the GitLab rules docs: https://docs.gitlab.com/ci/jobs/job_rules/). In a normal branch pipeline this variable is unset while the rule is evaluated, so $HAS_OPEN_PR != "true" matches and excludes the upload job even when the PR check would later write HAS_OPEN_PR=true; as a result the system-tests artifacts/image never get published for open PR branches.
Useful? React with 👍 / 👎.
| fi | ||
| fi | ||
| # Normalise the arch tarball names so the GitHub Actions side needs only the branch slug. | ||
| DEST="s3://dd-trace-php-builds/ci/${CI_COMMIT_REF_SLUG}" |
There was a problem hiding this comment.
When two pipelines for the same branch overlap, both upload to the same ci/${CI_COMMIT_REF_SLUG} keys while the old per-slug resource_group was removed. The GitHub workflow later downloads from that shared prefix by slug, so a slower older pipeline can overwrite some or all of a newer pipeline's artifacts before either dispatch downloads them, causing the branch tag to be pushed with stale or mixed package contents; keep the upload/dispatch serialized per slug or use a unique prefix per pipeline/commit.
Useful? React with 👍 / 👎.
| - when: always | ||
| needs: | ||
| - job: "publish docker image for system tests (upload)" |
There was a problem hiding this comment.
In the intended no-open-PR path, the upload job is configured to be omitted, but this dispatch job is still added for every non-default branch and has a hard needs edge to that omitted job. GitLab documents that needs pointing at a job excluded by rules can make pipeline creation fail unless the need is optional (https://docs.gitlab.com/ci/yaml/), so branches without an open PR can fail the package child pipeline instead of cleanly skipping system-tests image publishing.
Useful? React with 👍 / 👎.
27419ba to
d25554f
Compare
d25554f to
74a4136
Compare
1 participant
Stacked on #4065 — needs the GH Actions workflow merged to master first
(
workflow_dispatchresolves the workflow by filename against thedefault branch, regardless of dispatch
ref).Summary
check open pr for system testsjob that gates on an openGitHub PR before anything is uploaded to S3, addressing:
fix(ci): publish system-tests image via S3 + GH Actions dispatch #4065 (comment)
check via a dotenv artifact.
Test plan
dispatch + image push succeed end to end